theodi / octopub

Publish data easily, quickly and correctly
https://octopub.io/
Other
41 stars 18 forks source link

Report schema and validation errors more fully #197

Open pezholio opened 8 years ago

pezholio commented 8 years ago

At the moment, if a csv doesn't match a schema, we just get a 'Schema not valid' error. It would be good if we got something a little more helpful.

Relevant code here:

https://github.com/theodi/octopub/blob/master/app/models/dataset_file.rb#L75

rachelwilson commented 6 years ago

For 2018 Q4 UX work (P1): If the validator returns something like an array or errors that we can simply display we could do that. At the very least change the error message to something more like "The data in the CSV file doesn't comply with the associated schema. Please review the data in the CSV file, make necessary corrections and resubmit for validation". Maybe point them at csvlint where they can get more better feedback?

If it's going to be more than half a days work to get more fine-grained error messages out of the validator I'd suggest addressing this issue at a later date (when we look into schemas)