search

theodi / octopub

Publish data easily, quickly and correctly
https://octopub.io/
Other
41 stars 18 forks source link

Move back to jsontableschema release #428

Open Floppy opened 7 years ago

Floppy commented 7 years ago

In order to fix #410, we are using a fork of jsontableschema at https://github.com/floppy/jsontableschema-rb. Once https://github.com/frictionlessdata/jsontableschema-rb/pull/15 is merged and a release cut, we can go back onto the mainline.

quadrophobiac commented 7 years ago

for clarity this is to fix this state of affairs https://github.com/theodi/octopub/blob/master/Gemfile#L24-L28

That change has been merged into master, not sure what you mean by "release cut" @Floppy, could you elaborate?

What are the next steps? I think this work should be tethered to this ticket within the gem https://github.com/theodi/csvlint.rb/issues/189

Floppy commented 7 years ago

It'll need a gem version released so we can use it directly, though we could move back to the original master if we want to, as an interim.

Floppy commented 7 years ago

Ah, looks like 0.2.1 and above include this change, so yes, we can go back to the gem now as long as we specify ~> 0.3

Floppy commented 7 years ago

Meant to add this as a link: https://github.com/frictionlessdata/tableschema-rb/commits/master

The CHANGELOG file on the jsontableschema gem isn't being maintained, sadly, so it's just a matter of looking at the commits.