search

theodi / open-data-certificate

The mark of quality and trust for open data
https://certificates.theodi.org/
MIT License
46 stars 39 forks source link

Setup for delayed_job #1694

Closed ghost closed 5 years ago

ghost commented 5 years ago

This PR fixes #1693

Changes proposed in this pull request: Added gem needed to run delayed_job as daemon from script (if needed) Added back heroku container to run delayed_job to ensure that the rake task: 'odc:generate_dataset_csv' can be picked up.

I have already tested the this rake job with data (and uploaded to rack under another name) to ensure the full csv is uploaded there. While I haven't tested what behaviour occurs yet for downloading a dataset of this size, this changes should at least provide flexibility in allowing delayed_job to run in the background.

I don't have access to the heroku setup/config or the travis setup beyond .travis.yml, but please let me know if there are some circumstances here that don't allow for this change. Otherwise we can look at what else needs to happen to ensure this is scheduled at an appropriate time. For now I can kick off initial the csv export so that we have the latest in rack.

ghost commented 5 years ago

Hi @olivierthereaux Any update on this? Anything I can do?

olivierthereaux commented 5 years ago

@mattRedBox we're a bit thin on the ground so I had a look through, merged and deployed to staging. Can you test there before we push to production?

ghost commented 5 years ago

No problem @olivierthereaux I'll start doing that this week and let you know the results.