theodi / shared

Repo that we use for non-repo-specific stories and other shared stuff.
22 stars 1 forks source link

After providing a data.gov.uk URL on the first page, it never progresses (#836) #301

Closed sumikasan closed 10 years ago

sumikasan commented 10 years ago

https://github.com/theodi/open-data-certificate/issues/836

pezholio commented 10 years ago

This highlights the need for more robust error catching for the url checking

pezholio commented 10 years ago

@JeniT - Which dataset were you trying to validate in the meeting earlier? I thought it was English Indices of Deprivation, but that works for me :/

JeniT commented 10 years ago

Yes, http://data.gov.uk/dataset/index-of-multiple-deprivation.

Maybe I have some weird cookie thing going on?!?

Jeni

-----Original Message----- From: pezholio notifications@github.com Reply: theodi/shared reply@reply.github.com> Date: 4 August 2014 at 15:14:46 To: theodi/shared shared@noreply.github.com> Cc: Jeni Tennison jeni@theodi.org> Subject:  Re: [shared] After providing a data.gov.uk URL on the first page, it never progresses (#836) (#301)

@JeniT - Which dataset were you trying to validate in the meeting earlier? I thought it
was English Indices of Deprivation, but that works for me :/


Reply to this email directly or view it on GitHub: https://github.com/theodi/shared/issues/301#issuecomment-51065272

Jeni Tennison, Technical Director theODI.org
+44 (0) 7974 420 482 @JeniT

pezholio commented 10 years ago

I can't replicate this, but I am going to spend some time trying to speed up the data_kitten stuff, which I suspect is the root cause of this.

pezholio commented 10 years ago

Ah, OK. This is a problem, however, I can't catch it. If I have the Javascript console open it works, but when I don't I get a 500 response, but nothing comes up in Airbrake. WHAT DID YOU SEE?

pezholio commented 10 years ago

A sort of fix is here:

https://github.com/theodi/open-data-certificate/pull/847

I struggled to replicate the issue, so I think this is an edge case. Instead, I've just added better error handling and feedback to the user.