search

theodi / shared

Repo that we use for non-repo-specific stories and other shared stuff.
22 stars 1 forks source link

Send signup details straight to Capsule #627

Closed pezholio closed 9 years ago

pezholio commented 9 years ago

Also, first and last names are getting mangled

pezholio commented 9 years ago

So, currently the situation goes like this:

Presumably now, as we're not using Xero - we can cut the invoice creation out, and send all the necessaries straight to Capsule - @pkqk - does that sound correct?

pkqk commented 9 years ago

@pezholio yep. I would cut out the entire Xero step. There is enough info from the Chargify signup to populate Capsule.

As long as if necessary the Xero integration can also happen.

Floppy commented 9 years ago

We'd just need to be sure that Xero will still make the link to the capsule data. I think it will, but I'm not 100%. It's flaky as hell though anyway, as it assumes things like UNIQUE NAMES. (sigh)

pezholio commented 9 years ago

Do we even need to make the link between Xero and Capsule, as we're using Chargify now?

Floppy commented 9 years ago

Mm, I don't know what Chargify does, but I know that link allows people to see unpaid invoices in Capsule... I'm not sure. @greenreveller might know best.

pkqk commented 9 years ago

@Floppy there should be no unpaid from chargify as it's :credit_card: only

JeniT commented 9 years ago

Please check with finance (Alison) about whether they need to see information about the paid invoices in Xero. They might need something like that for tracking purposes.

Floppy commented 9 years ago

Good plan; @alisonwalters, any thoughts?

pezholio commented 9 years ago

We can probably keep this in and remove the Capsule / Xero integration anyway if it causes any problems. The issue seems to be that the integration isn't working properly, and email addresses aren't getting copied over to Capsule, so it's probably best not to rely on third parties and do it ourselves.

pezholio commented 9 years ago

Right, so, the issue we have is that some contacts exist already in Capsule - if they sign up with a different email (i.e. we've contacted them via their work email, and they sign up with their personal email) then the link is created against that contact in Capsule, and when SignupProcesser runs, they never get found in Capsule because we key on email.

There are therefore a few options here:

The first option is the quickest and dirtiest, but will probably bite us in the ass further down the line, and the third option seems like a bit of a cheat, but would definitely work. The second option is the neatest, but might take a couple of days, and may end up being superseded once we stop raising invoices in Xero.

Any thoughts?

alisonwalters commented 9 years ago

Hi, Sorry I'm working on some urgent finance deadlines just given to me by Louise. I will anseer as soon as I can

Ali

On 19 May 2015 at 12:26, pezholio notifications@github.com wrote:

Right, so, the issue we have is that some contacts exist already in Capsule - if they sign up with a different email (i.e. we've contacted them via their work email, and they sign up with their personal email) then the link is created against that contact in Capsule, and when SignupProcesser runs, they never get found in Capsule because we key on email.

There are therefore a few options here:

  • We search by the person's name, rather than email - Capsule keys on person name anyway, so this assumption matches up with how the Xero / Capsule integration works. This falls down when we have people with the same name though.
  • We do away with the auto integration, and roll our own; or
  • When we create the contacts in Xero, we add the membership ID in brackets, so all names are unique

The first option is the quickest and dirtiest, but will probably bite us in the ass further down the line, and the third option seems like a bit of a cheat, but would definitely work. The second option is the neatest, but might take a couple of days, and may end up being superseded once we stop raising invoices in Xero.

Any thoughts?

— Reply to this email directly or view it on GitHub https://github.com/theodi/shared/issues/627#issuecomment-103449820.

pezholio commented 9 years ago

Hey Alison, I think we're going to keep the Xero situation as it is for now :smile:

pezholio commented 9 years ago

Tagging @greenreveller in this conversation

greenreveller commented 9 years ago

As discussed, I'm for the second option (e.g. doing away with auto integration and creating our own system) as it will also solve the 'convert to person' problem with individual Supporters. Aware that this may mean needing to merge capsule entries where a person already has an entry.

And just to check - in the instance where someone has an entry in capsule and signs up using the SAME email this will work fine? (it does at the moment but just want to verify how this new approach would work). Would a new entry be created on would membership be added to an existing Capsule entry?