search

theodi / shared

Repo that we use for non-repo-specific stories and other shared stuff.
22 stars 1 forks source link

ENV namespacing #692

Open pikesley opened 9 years ago

pikesley commented 9 years ago

We now have a better .env mechanism, and I've now uncovered a namespacing problem. For example, we have:

AIRBRAKE_API_KEY:
AIRBRAKE_CALENDAR_KEY:
AIRBRAKE_CERTIFICATE_KEY:
AIRBRAKE_DIRECTORY_KEY:
AIRBRAKE_GIT_VIEWER_KEY:
AIRBRAKE_SERVICES_KEY:
CSVLINT_AIRBRAKE_KEY:
DASHBOARDS_AIRBRAKE_KEY:
QUIRKAFLEEG_AIRBRAKE_KEY:

There are almost certainly more. Shouldn't be too hard to fix

pikesley commented 9 years ago

See also SESSION_SECRET_CERTIFICATE -vs- CSVLINT_SESSION_SECRET

Floppy commented 9 years ago

yeah, we improved the way we did this at one point but never backported the change to pre-existing apps.

tech debt