search

theodo-group / LLPhant

LLPhant - A comprehensive PHP Generative AI Framework using OpenAI GPT 4. Inspired by Langchain
MIT License
759 stars 75 forks source link

Support for ElasticSearch v7 #127

Open jmariller opened 3 months ago

jmariller commented 3 months ago

Hi,

First of all thanks a lot for this library.

In the project I am working on we are using jolicode/elastically, which is indirectly (via ruflin/elastica) based on version 7 of elasticsearch/elasticsearch.

Now I would like to use ElasticsearchVectorStore, however I am not able to pass the proper ElasticSearch client as the namespace changed from v7 to v8.

Is there any way that the LLPhant could support ElasticSearch v7 as well?

Cheers

MaximeThoonsen commented 3 months ago

Hey @jmariller,

Sure I will add it as a feature request. Is this something that you would want to contribute?

jmariller commented 3 months ago

Hi @MaximeThoonsen thank you for your answer! I would be happy to help, however in the meantime I noticed that there were changes in the namespaces of Elastisearch between v7 and v8, making such a feature pretty tricky - I am wondering if it is even possible? So I am currently rather trying to help the maintainers of jolicode to have their elastically library migrate to v8. So I guess we can put this issue on hold for the moment.