theodor349 / Work-Tracker

A place to log the time you use working for different employers with the ability to export timesheets
MIT License
5 stars 1 forks source link

UI in blazor #3

Open musictopia2 opened 2 years ago

musictopia2 commented 2 years ago

Another suggestion I have which I can help with is having the UI in blazor. I am very good at blazor. I found blazor to be the best for UI which allows sharing UI with web pages and even native apps as well with blazor hybrid.

theodor349 commented 2 years ago

My plan was also to use Blazor, however frontend development is not what I'm best at. So some help on that side would be great.

musictopia2 commented 2 years ago

I am great at the cosmetics of it. I am good at basic layout but not as good at graphics. I can do what I can. I have many blazor components to help as well. Here is my repository https://github.com/musictopia2/BlazorBasicLibrariesSolution It has many common components that are useful for many projects.

theodor349 commented 2 years ago

I'm currently setting up a new Blazor Webassebly PWA client. When I have that working I'll quickly make a rough draft of what pages I image should be part of a minimal viable product (MVP).

Maybe you'd like to take a look at that afterward?

musictopia2 commented 2 years ago

No problem. I would suggest doing as a razor class library. If its a razor class library, then it can be shared between PWA and even desktop or mobile native as well. I am good at putting images in if you have images to use. I'm just not good at finding images to use.

theodor349 commented 2 years ago

Do you know if you can add a pull request to an issue without closing the issue?

I also just added the Blazor app

musictopia2 commented 2 years ago

I am guessing that if you link a pull request to an issue, then it closes the issue. If you do a pull request but don't link it, then it would not close the issue. You can still mention the pull request. I have not had much experience with pull requests and issues.

musictopia2 commented 2 years ago

For the work I do on my projects, I don't even do pull requests. I just commit directly. In that case, would be no issue. I would think pull requests work best when external people work on the projects.

theodor349 commented 2 years ago

Yea, not linking the pull request is probably easiest.

I actually find it fairly nice to merge the branches with pull request.

musictopia2 commented 2 years ago

I found the easiest if working on another branch is using the feature from visual studio where you create and push a branch. Then when finished, then use option to merge to current branch. I found that the easiest.

theodor349 commented 2 years ago

@musictopia2 I have just pushed a very rough draft of the three pages I think is part of the MVP. If you want to make have a look at it and make it prettier you are very welcome :)

musictopia2 commented 2 years ago

What I would suggest which I can do with your permission is to have a razor class library for all the blazor ui stuff. This would mean in the future if you want to use in a wpf or even maui android, etc, you can do so its not just tied to webassembly. If I have your permission, I will go ahead and move to library and make sure the webassembly uses it. So the webassembly just references the libraries. This would mean all your changes will be to the back end, razor class library or the shared library.

theodor349 commented 2 years ago

Sure it would be great if you would do that, because I'm not sure how much should be moved out of the current Blazor app.