search

theodore-norvell / PLAAY

Senior Design Project PLAAY (Programming Language for Adults And Youth)
2 stars 0 forks source link

Clear ready flag on return from function #111

Closed theodore-norvell closed 6 years ago

christopher-rodgers commented 6 years ago

I checked out this branch and when I tried running the tests, it gave me this:

TypeError: Cannot read property 'notifyOfBirth' of undefined

Seems to be something to do with the manager in backtracking.

jillhancock commented 6 years ago

I was experiencing the exact TypeError @christopher-rodgers ran into for the past few hours. It was telling me that creating a new World in world-tests.ts was failing; the TransactionManager being passed to super (i.e. ObjectV) in World's constructor became undefined. I tried explicitly importing ObjectV in word-test.ts and it fixed the tests for me, but now I can't recreate the issue so I don't think this is actually a fix!

christopher-rodgers commented 6 years ago

I fixed mine by deleting all the javascript files and re-compiling. I guess it just had something to do with old javascript files sticking around when they shouldn't have been. Either way it's fine now, I am going to merge this.