search

theodore-norvell / PLAAY

Senior Design Project PLAAY (Programming Language for Adults And Youth)
2 stars 0 forks source link

keyboard tabs #71

Closed WNewhook closed 7 years ago

WNewhook commented 7 years ago

@inexpensive @jillhancock @christopher-rodgers Here's the pull request for moving between placeholder with tab. I couldn't get the browser to ignore the tab when closing a label, but it works for navigation.

theodore-norvell commented 7 years ago

I think that's the right thing to do.

WNewhook commented 7 years ago

@inexpensive @jillhancock @christopher-rodgers I managed to get tab working to close labels by changing the input handler from acting on keyup to keydown. It works for me, but can you guys take another look?

theodore-norvell commented 7 years ago

I like being able to end the input of a string with a tab. That's a nice touch.

But I noticed if I add a callworld node with say two place holders and then select this call world node, so the situation is like this (! is anchor and ^ is focus)

        someNode( someNode(), ! callWorld[+]( ExpPH() , ExpPH() ) ^ , someNode() )

then tab will not move to the first ExpPH. This is because of the way I defined moveRight and moveLeft in the winter.

I'd propose changing the interpretation of moveRight and moveLeft. This affects the right, left, up and down keys too, but in a good way, I think.

My proposal is in commit 60c81f188220db3fb50e5de79295669b0bd2fe58 on branch ImprovedMoves. If you think it's ok, merge it into this branch before merging this pull request.