search

theodoreb / theodoreb.github.io

read.theodoreb.net
0 stars 1 forks source link

Post: Fixing contrib javascript #5

Open theodoreb opened 10 years ago

theodoreb commented 10 years ago

Comments for Fixing contrib javascript.

theodoreb commented 10 years ago

Sorry about the link spaming, I'll try to have less distracting things for you to look at next time.

Just leaving a comment to show they display directly under the article now, no need to visit the github page to read them :)

mikeytown2 commented 10 years ago

AdvAgg has the validator submodule which can run JSHint on your drupal install. It also has the mod submodule which has an option to not include jQuery if jQuery is not going to be used (jQuery and Drupal JavaScript libraries and settings are output even when no JS is added to the page).

theodoreb commented 10 years ago

Ooh that's really nice! I didn't know about that. Looks like the patch was close to RTBC for 7 no? Care to do one more review on it so it might make it in core? :)

What I hope happens with JSHint is that it's run before the automated test on the testbot and on projects that have CI set up ; to be able to do that all of core, contrib and custom must validate. The clientside JSHint validation is really neat, could definitely see that in the coder module :D