search

theodorekwok / pe

0 stars 0 forks source link

Error when finding a tag that exist #16

Open theodorekwok opened 2 years ago

theodorekwok commented 2 years ago

error 16.PNG

If i modify the save file tags to have '+' character. I cant find that tag even though it exist

soc-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error when deleting a tag that exist

error 15.PNG

If i modify the tag in the saved file to have '+' characters, although the tag exist, I cant delete it

[original: nus-cs2113-AY2122S1/pe-interim#1827] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

You were told to edit the saveFile at your own risk.

Screenshot 2021-11-13 at 1.42.46 PM.png

This issue will not happen if you had tried to enter a tag with "+" within its name, as it is not allowed due to the syntax of the command.

Screenshot 2021-11-13 at 1.47.25 PM.png

If you further insist on a tag with "+" within its tagName, and edit the saveFile in order to do so, any errors are again at your own risk.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I disagree with it being a duplicate as this is an issue on 2 different features, the delete and find tag features. The team did not provide any argument to convince me that this is a duplicate.

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: From the UG, it does not state anywhere that tag with "+" in its name is not allowed. The team's UG provided this warning "You cannot use “/” in the recipe name, ingredients or steps." but no similar warning for "+" was provided. The team's reasoning of how I shouldn't use "+" due to the syntax of the command is incorrect reasoning as it assumes I as a user a possible non-programmer would know how their program parse function works.

As for editing the save file at my own risk, this implies that I must know what text/words I can use as inputs when those details are not provided by the UG. This makes it extremely restrictive to me as a user given that now everytime I want to create/change a tag I must know what characters to avoid making the feature almost useless.