theodorekwok / pe

0 stars 0 forks source link

Parser sequence diagram (add command) incorrect notation #18

Open theodorekwok opened 2 years ago

theodorekwok commented 2 years ago

ss2.PNG

The section circled in red should be called from the activation bar of the addRecipeParse() when referring to the code

nus-se-bot commented 2 years ago

Team's Response

This is indeed a bug. However since the section is still being called from addRecipeParse, which is an instantiation of the :Parser class, the implementation of the code in the circled session is completely unaffected.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: I disagree with the downgrade as this is not a cosmetic issue but an issue with the correctness and accuracy of the diagram. The team's response about how implementation of the code is unaffected is incorrect. This is because as a reader when referring to the code while looking at this diagram this inaccuracy is confusing and hinders my understanding of the project. It gives me the wrong idea of what method calls what method.