search

theodorekwok / pe

0 stars 0 forks source link

Wrong error Message when index is given for deleteRecipe #2

Open theodorekwok opened 2 years ago

theodorekwok commented 2 years ago

error 1.PNG

^Above a very large number was given, but the error message told me to provide a valid integer

nus-pe-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Set time on large integers invalid, although UG states that they should be.

UG states that

image.png However, inputting the below command yields an exception, although 9999999999 is an integer.

image.png

[original: nus-cs2113-AY2122S1/pe-interim#881] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is an issue with the Integer object within Java itself.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I disagree that this is a duplicated issue as it is about the indexing of deleteRecipe feature and not about the set feature. Moreover the team did not provide any explanation for why this is a duplicate to convince me.

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree that this is notInScope as the issue lies in the specificity of the error message which should have been something that is taken into consideration since version 1.

:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: I believe the severity should be low not medium given that it is extremely rare for users to have that many recipes.