theodorekwok / pe

0 stars 0 forks source link

Parser sequence diagram (add command) #20

Open theodorekwok opened 2 years ago

theodorekwok commented 2 years ago

ss4.PNG There no such call to addRecipe method in the addCommand constructor

nus-pe-script commented 2 years ago

Team's Response

addRecipe can be found in the AddCommand class under the execute function.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Yes addRecipe method can be found under the execute function. The diagram shows an AddCommand constructor activation bar. From the AddCommand constructor code: "
public AddCommand(Recipe recipe) { this.recipe = recipe; } "

There is no call to the execute method. Therefore the constructor activation bar should have no method calls at all. The error still stands.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: I disagree with the severity downgrade as this pertains to the correctness and inaccuracy of the bug and nothing to do with cosmetic/style issues.