search

theodox / mGui

Python module for cleaner maya GUI layout syntax
MIT License
123 stars 23 forks source link

Removing Control.from_existing #74

Closed bob-white closed 7 years ago

bob-white commented 7 years ago

It has been superseded by Control.wrap, should solve #73

bob-white commented 7 years ago

I think this is safe, but I don't have anything that is using PanelFactory which was the only item I could find using from_existing so I could do some rather minimal testing.

Plus I'm not sure if anyone else out there is actually relying on from_existing in their local code.

theodox commented 7 years ago

I think this is OK, although we should wait until I can put up a notice about it before we merge it into main. Maybe we should include an extension of gui.derive along with this this and then push the pair as a point release?

bob-white commented 7 years ago

We could do an interim step where we leave from_existing as an alias to wrap and add a deprecation warning.

theodox commented 7 years ago

In the interest of preventing issues from propagating, I'd just make it fail instead of warning. We can include a fix note in the comment.