search

theofidry / AliceBundleExtension

Behat extension for HautelookAliceBundle.
MIT License
36 stars 23 forks source link

Load several fixtures on same time #11

Closed supertanuki closed 9 years ago

supertanuki commented 9 years ago

Ping @theofidry

theofidry commented 9 years ago

Thanks for the work @supertanuki. But would it be possible to pass a table of fixtures files rather than a string? Like:

Given the following fixtures files are loaded:
| file1 |
| file2 |
...

It would be more readable IMO when having lots of files.

supertanuki commented 9 years ago

@theofidry You're right. Thanks. It is fixed.

theofidry commented 9 years ago

Removed the preset PSR-0 blocking StyleCI. Could you push an empty commit to trigger a new StyleCI check?

supertanuki commented 9 years ago

@theofidry Done ! I updated the readme (not an empty commit...)

theofidry commented 9 years ago

Good, just the StyleCI + rebase :)

supertanuki commented 9 years ago

I rebased to upstream/master. The StyleCI analysis still failed. What's wrong?

theofidry commented 9 years ago

Check out the result: https://styleci.io/analyses/zELLvq

You just need to use the short array annotation for it to pass.

supertanuki commented 9 years ago

@theofidry thanks, done !

theofidry commented 9 years ago

Thank you @supertanuki

theofidry commented 9 years ago

Erf did not rebase, too late.

supertanuki commented 9 years ago

What?

theofidry commented 9 years ago

Sorry I was not clear, I meant to rebase to squash the 4 commits into 1. It was my mistake for not checking and fortunately it doesn't have that much of an impact ;)

Anyway merged and tag released!