search

theofidry / AliceBundleExtension

Behat extension for HautelookAliceBundle.
MIT License
36 stars 23 forks source link

[WIP] allow alice-bundle 2.0 and be ready for Symfony 4 #28

Closed OskarStark closed 6 years ago

theofidry commented 6 years ago

Thanks for the PR! I think HautelookAliceBundle could be ditched in favour of AliceDataFixtures

OskarStark commented 6 years ago

Hey @theofidry

I am just trying to get things working again 😄 Good catch, I will try to use that dependency.

Do you think it is a big rewrite?

theofidry commented 6 years ago

Do you think it is a big rewrite?

I'm not sure :) But AliceDataFixtures has the necessary loaders, what HautelookAliceBundle really provides is the finder to automatically find the fixtures and the loader command which uses it, but we're not using it in the extension... In HautelookAliceBundle 1.x everything was kinda mixed in the bundle because of the design limitations of alice 2.x

OskarStark commented 6 years ago

Sorry I didn't have more time to dive deeper into this topic 😢

theofidry commented 6 years ago

No worries @OskarStark