search

theoforger / mastermind

An LLM-powered CLI tool to help you be a better spymaster in Codenames
GNU General Public License v3.0
3 stars 2 forks source link

Adds support of usage of a TOML "dotfile" config file in the user's homedir (In-Progress) #19

Open mulla028 opened 1 day ago

mulla028 commented 1 day ago

Description

This is a draft pull-request that allows us to communicate along with arrival of the new commits.

What's new ?

Cargo.toml file updated, it acquired new dependency called "TOML"

Closes #18

theoforger commented 1 day ago

Thanks for the contribution! Can you make a separate module for this new feature?

Simply declare the module inside lib.rs:

pub mod config;

And then add your code inside config.rs.

Happy coding!

mulla028 commented 1 day ago

Thanks for the contribution! Can you make a separate module for this new feature?

Simply declare the module inside lib.rs:

pub mod config;

And then add your code inside config.rs.

Happy coding!

Yes, for this feature the best practice would be to wrap the entire implementation in a separate module. Thank you for your attention!

mulla028 commented 1 day ago

I have marked this pr as ready for review; however, if you are satisfied with the result, do not merge. I still have to comment the code.

theoforger commented 1 day ago

Just letting you know that I merged another branch to main, which I just merged into this branch as well.

Also, I added linting check to the GitHub Actions workflow. Make sure you run cargo fmt on the local project before pushing.

Thanks!