search

theoforger / mastermind

An LLM-powered CLI tool to help you be a better spymaster in Codenames
GNU General Public License v3.0
3 stars 2 forks source link

-v flag does not display version #2

Closed mayank-Pareek closed 2 weeks ago

mayank-Pareek commented 2 weeks ago

Description:

The -v flag is expected to display the version of the CLI tool according to the release 0.1 requirements, but currently it is not recognized. The -V flag which is clap default, works and displays the version as intended. When trying to use -v, an error is thrown.

Screenshot:

image

Steps to reproduce:

  1. Run the command: cargo run -- -v
  2. Notice the error message: 
    error: unexpected argument '-v' found

    Expected behavior:

    The -v flag should display the version of mastermind, as specified by release 0.1 requirements.

Actual behavior:

The -v flag throws an error, while the -V flag correctly displays the version.

Environment:

theoforger commented 2 weeks ago

This project uses clap for arguments handling. It is an upstream decision to use -V to display version number.

For more information, see: https://github.com/clap-rs/clap/issues/138

mayank-Pareek commented 2 weeks ago

As mentioned in the issue comments, the default can be overridden https://github.com/clap-rs/clap/issues/138#issuecomment-1557690932 . You can close this issue if you do not intend to override the default verbose option.

theoforger commented 2 weeks ago

I'll keep it this way to leave room for a possible --verbose option in the future. Appreciate the suggestion though 🙏