search

theolivenbaum / electron-sharp

MIT License
24 stars 4 forks source link

Update SocketIO #6

Open lofcz opened 1 year ago

lofcz commented 1 year ago

This PR updates included SocketIO code to 8d5d25c51ac6257f4bcbe8cf0c67d097ecb2861f.

This comes with three benefits:

  1. should something happen during the connection phase, we now time-out eventually instead of hanging forever (cancellation tokens are passed around and requests to cancel checked in while loops)
  2. allocations significantly reduced
  3. fixes for various bugs in the library, see their changelog.

The only front-facing change is EIO changed to Enum from int, which is reflected in BridgeConnector. I've tested SampleApp against this branch and it works.

Edit 1: updated to 8d5d25c51ac6257f4bcbe8cf0c67d097ecb2861f

theolivenbaum commented 1 year ago

Hi @lofcz thanks for the changes! I started reviewing them here - but I'll need to do some more testing before merging. One issue I found was when starting the sample app using the await Electron.Experimental.StartElectronForDevelopment(webPort); mode, it failed to exit in a reconnecting loop. Maybe if you've some time to check that, otherwise I'll take a look as soon as I've some time again!