Add libtorch dependency

[tigroo31]

Fix #35

Add the full libtorch dependency (to be able to directly compile after the clone).

Use the include directory at the same level of the exchange binary (to be able to easily handle the runtime into a docker image).

Process a non regression test:

1. from your host:

• update the TO_config.json INTO THE BUILD DIRECTORY

2. through the docker image to accept this request:

• build docker image & run docker image

• once in bash on the container ./runner.sh

[theomarzaki]

Hello,

@tigroo31 , I am a bit confused with the changes (my problem),

I was wondering why cmake 3.11 was necessary since the latest version of cmake available by apt is 3.10, therefore, there is additional installation and dependancies added to the directory ?

Most, of the required files in pytorch, are being modified, causing some of the functionality not to work as expected, when the './runner.sh' command is entered, missing files linking to the modified files in git are shown as an error. Perhaps, when the branch Is merged a unified version of the libtorch library can be committed to master , and we can continue from there ?

Thank you !

[tigroo31]

Hello,

@tigroo31 , I am a bit confused with the changes (my problem),

I was wondering why cmake 3.11 was necessary since the latest version of cmake available by apt is 3.10, therefore, there is additional installation and dependancies added to the directory ?

Most, of the required files in pytorch, are being modified, causing some of the functionality not to work as expected, when the './runner.sh' command is entered, missing files linking to the modified files in git are shown as an error. Perhaps, when the branch Is merged a unified version of the libtorch library can be committed to master , and we can continue from there ?

Thank you !

Hi! I pushed a new version fixing the Docker build and run using a debian buster instead of an ubuntu latest, and downloading the libtorch zip file.

[tigroo31]

You can use your host instead of docker during the integration sessions ;). You can also just trigger the « make » once the « cmake » succed one time : we download the libtorch on configuration step, before to compile. NB: like said, we´ll deploy each night, into our Orange Cloud, another TO instance always available, connected to the online v2xgateway : you may have your ssh key to connect to if needed.

Le 1 avr. 2019 à 20:06, Omar Zaki notifications@github.com<mailto:notifications@github.com> a écrit :

@theomarzaki approved this pull request.

Perfect, Thank you very much.

The changes work perfectly when I tested them.

Although compiling and building the image at my local host during the integration sessions will take a while ! :P

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/theomarzaki/lstm-rl/pull/34#pullrequestreview-221263819, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Atk4blXGt7DALBc4T-qJ6totVyMV-9zMks5vckq5gaJpZM4cQqvz.

---

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.

[theomarzaki]

Ahh Perfect, using ssh should be the ideal solution. since my main OS unfortunately isn't a linux distro