search

theomenden / TheOmenDen.Vanadium

A simple Custom Colors Mod for minecraft Fabric
https://modrinth.com/mod/vanadium
GNU General Public License v3.0
23 stars 3 forks source link

[BUG] #35

Open dophire opened 1 year ago

dophire commented 1 year ago

I'm using Vanadium mod for custom colors since Colormatic hasn't been updated to 1.20.1 and I'm using Bedrock Waters color resourcepack. Everything works perfectly until I fill a cauldron with water and then the game crashes when trying to render it. It seems like it is caused by the fact that Sodium added "Cauldron blocks no longer force the use of smooth biome color blending for the fluid contents." to 0.5.2.

Reproduction Steps Use the latest Sodium + Indium + Vanadium. Use a resource pack that changes the water colors. Place a cauldron and fill it with water, and the game will crash. crash-2023-09-08_22.22.23-client.txt

Expected behavior The water-filled cauldron will render properly and won't crash the game.

Desktop

AluTheCrow commented 1 year ago

I'm unable to reproduce this with Sodium, Indium, and Vanadium only.

However, I can reproduce this with Continuity. Reviewing this further

dophire commented 1 year ago

I see! Thank you! I assumed it was indium/sodium because it was stated as an Indium Render error, but continuity does make sense!

AluTheCrow commented 1 year ago

No worries! I really appreciate you bringing this up, I'll try and work on a solution from my end, but I'm not sure how successful I'll be - would you mind poking around on the Continuity github or discord and see if there's an issue too?

dophire commented 1 year ago

I'll see what I can do!

dophire commented 1 year ago

This is the closest thing I found to our issue https://github.com/PepperCode1/Continuity/issues/273

AluTheCrow commented 1 year ago

Update - I think I have the fix for this, and should be released this weekend with 0.1.7

dophire commented 1 year ago

Ayyy, great to hear! Thanks!

sasquott commented 1 year ago

New test build of Continuity (3.0 beta4) for 1.20.2 is available in test builds, Peppers Discord, Vanadium no longer crashes with Continuity running, but also does not work as intended, looking forward to seeing 0.1.7 soon? (Vanadium 0.1.625 works fine in 1.20.2 without Continuity running btw)

AluTheCrow commented 1 year ago

I believe I've figured out more of the registry issue - so at least in vanilla it works, with continuity and Athena. Going to try for Modded biomes.

dophire commented 1 year ago

Yay! Any info on when the new version will be released by any chance?