theomenden / TheOmenDen.Vanadium

A simple Custom Colors Mod for minecraft Fabric
https://modrinth.com/mod/vanadium
GNU General Public License v3.0
22 stars 3 forks source link

[BUG] Unintentional(?) modifying of vanilla colors? #37

Closed Chilly-roll closed 1 year ago

Chilly-roll commented 1 year ago

Describe the bug It seems that Vanadium is messing with the vanilla colors (and more, unable to indentify it as easily) without any particular reason why. I quickly noticed this being the case with biome colors--

Vanilla Plains Color Vanilla

Vanadium Plains Color Vanadium

Totally possible I missed something, though unlikely given that I've also isolated it to being a problem with this mod specifically, even with just running it with only the necessary dependencies.

This was tested on the latest alpha release on Github (0.1.65)

AluTheCrow commented 1 year ago

It's semi-intentional as a way to get around sodium's color providers. We have to bypass them and provide a sort of recalculation for colors.

We're working around this problem though, and trying to figure out how to do this without modifying the underlying vanilla behavior. Should hopefully be fixed in 0.1.7

Chilly-roll commented 1 year ago

Alright, good to know! Thanks for the info.