search

theomenden / TheOmenDen.Vanadium

A simple Custom Colors Mod for minecraft Fabric
https://modrinth.com/mod/vanadium
GNU General Public License v3.0
24 stars 3 forks source link

[BUG]Grid Colormap Format biome IDs out of order #67

Open Cedric-Vii opened 2 months ago

Cedric-Vii commented 2 months ago

Describe the bug When using the Grid format for colormaps, Vanadium is not properly reproducing Optifine's Grid layout. Vanadium appears to be using Biome IDs from before Minecraft 1.13 (as listed here), whereas Optifine now uses the modern Biome IDs (as listed here). This results in Vanadium displaying wildly incorrect biome colors in some instances when using Grid format.

To Reproduce Steps to reproduce the behavior:

  1. Load Optifine-compatible Grid colormap for grass using Vanadium.
  2. Look at any biome.
  3. Compare to the same colormap using Optifine.

Expected behavior Vanadium would apply tints from Grid colormaps using the same coordinates as Optifine 1.20.4-HD_U_I7

Screenshots N/A

Desktop (please complete the following information):

Additional context This obviously has significant potential ramifications for resource pack creators/users whose packs are rendered partially incompatible with Vanadium.

AluTheCrow commented 2 months ago

This explains a LOT! Thank you for this huge discovery, I really appreciate it. When I have some more time, I'll delve into this <3

Cedric-Vii commented 2 months ago

You're a saint! I went through and compared the list I made of Vanadium's order to the pre-1.13 ID list, and it's mostly the same. It starts to fall out of sync after ID 12, where pre-1.13 had more biome types, but it's still more or less the same in spirit. Thanks for all the work you've done already!

Rektroth commented 3 weeks ago

Is there any plan to get this done? Cause if not, I'd like to go ahead and fix it, in which case I need directed to where this list is. The only one I can find is in DefaultColumns and, as far as I can tell, while incorrect, it does not match the pre-1.13 list - and correcting it doesn't appear fix the problem anyway.