search

theonaunheim / surgeo

Open Source Proxy Demographic module written in Python
MIT License
32 stars 16 forks source link

Internal Renaming For Next Version #14

Open theonaunheim opened 3 years ago

theonaunheim commented 3 years ago

  1. Now that surgeo has both first name and surname models, it makes sense to disambiguate between these names in the data and source code. Every variable/column that is specific to a surname should be styled "surname" and every one that is a first name should be styled "first_name".

  2. Now that surgeo has both BISG and BIFSG models, the class of SurgeoModel should become BISGModel for consistency.

theonaunheim commented 3 years ago

Currently this is worked around by renaming the "name" column to "first_name" within first_name_model.py. That should probably occur in the source data and be used as the reference going forward.

TheCleric commented 3 years ago

Stupid question, would you then want to rename the package/repo for consistency? Though renaming the pypi package gets to be a pain. There are some tools to help though:

https://github.com/simonw/pypi-rename

theonaunheim commented 3 years ago

Probably not, unless someone else wants to do all the work.

I'm not married to the project name "Surgeo". That said, I'm also lazy ... and the thought of having to come up with a new name/logo and then re-do Travis CI, ReadTheDocs, and PyPI isn't something I'm looking forward to.