Census tract support - Githubissues

theonaunheim / surgeo

Open Source Proxy Demographic module written in Python

MIT License

32 stars 16 forks source link

Census tract support #16

Closed kindofluke closed 3 years ago

kindofluke commented 3 years ago

Adding support for census tracts via the CLI.

There are a few issues with this branch that may prevent merging.

All tests are passing but we don't have great tract level test data. We are working to run the original STATA data to get some valid testing.
the new CLI options are somewhat verbose
the GUI frontend does not support tracts as yet.

theonaunheim commented 3 years ago

Many thanks, @kindofluke .

I will review this weekend and start working through the PR.

Housekeeping item: can you please confirm you are OK licensing this contribution to surgeo via the MIT license? I am OK with you keeping copyright to your code and will add you to license/docs ... but I like to keep it under a single license for downstream users.

kindofluke commented 3 years ago

Sent via email

theonaunheim commented 3 years ago

Good afternoon, @kindofluke and @TheCleric . Thanks for the contributions and apologies for the delay; I wasn't able to address these last weekend.

These look great. I've merged them to dev for testing. I anticipate that I should be able to complete that today. After that I will:

accept the PR;
merge the dev modifications to master;
create the Windows EXE;
package for PyPI; and,
modify master with new links.

Should be able to wrap this up by Sunday evening CST.

kindofluke commented 3 years ago

Good afternoon, @kindofluke and @TheCleric . Thanks for the contributions and apologies for the delay; I wasn't able to address these last weekend.

These look great. I've merged them to dev for testing. I anticipate that I should be able to complete that today. After that I will:
* accept the PR;

* merge the dev modifications to master;

* create the Windows EXE;

* package for PyPI; and,

* modify master with new links.
Should be able to wrap this up by Sunday evening CST.

Theo, one other note I wasn't able to integrate census tracts into the tkinter app. Not sure i mentioned that.

theonaunheim commented 3 years ago

@kindofluke , understood. When I do the 2020 census rewrite I will shoot for parity with other models (probably by making separate SurTract and SurZcta models). For now adding this to the GUI is more trouble than it's worth.