search

theonaunheim / surgeo

Open Source Proxy Demographic module written in Python
MIT License
32 stars 16 forks source link

Removing a Duplicate Tract Function #17

Closed kindofluke closed 3 years ago

kindofluke commented 3 years ago

In real world use, the Surgeo model wasn't giving any strong results even though the geocode and surname models seemed to be working fine.

There seems to be an inconsistency in two similarly named functions so this cleans that up and corrects the errors.

theonaunheim commented 3 years ago

Hey, @kindofluke . Appreciate the heads up. I will take a look this weekend and see if we can merge.

kindofluke commented 3 years ago

Turns out the problem was in adjust_frame which is fixed in https://github.com/theonaunheim/surgeo/pull/17/commits/6827df8d865fef61c48619654a6855b1d4282cb4

theonaunheim commented 3 years ago

Hey, @kindofluke . Thanks for the PR. Will:

  1. Merge;
  2. Increment version in documentation and release notes;
  3. Repackage executable; and,
  4. Push new version to PyPI.