search

theonaunheim / surgeo

Open Source Proxy Demographic module written in Python
MIT License
32 stars 16 forks source link

Surgeo Model used wrong probability for tract #21

Open dypnani opened 1 year ago

dypnani commented 1 year ago

In surgeo model for "TRACT" version, the probability needed to be used according to official documentation was " Probability of tract given race". But in the model code i see that it used "_get_prob_race_given_tract()". The variable name is right but the data used is wrong.

self.geo_level = geo_level.upper()
    if geo_level == "TRACT":
        self._PROB_GEO_GIVEN_RACE = self._get_prob_race_given_tract()
    else:
        self._PROB_GEO_GIVEN_RACE = self._get_prob_zcta_given_race()

for zcta it is right but for tract wrong probability file was pulled.