search

theonemule / simple-openvpn-server

A setup script and simple web UI for setting up an OpenVPN Server
MIT License
232 stars 115 forks source link

rm /var/www/html/* #11

Closed crhbetz closed 4 years ago

crhbetz commented 4 years ago

https://github.com/theonemule/simple-openvpn-server/blob/6b811f9079fd40a23e9578d2c7d8fc76d3837c84/openvpn.sh#L274

Has it ever crossed your mind that /var/www/html might be used by anything other than this script?

Apparently it has, and you want it all gone - because why else would you want to delete everything before creating a single file in this folder?

This is a prime example for why one shouldn't trust random .sh scripts from github. I'm glad I run daily backups, but we know not everyone does. And using software from github shouldn't be the reason why we need backups.

theonemule commented 4 years ago

There's always a caveat emptor things like this.

I actually wrote this to be an appliance. It also installs a web server and configures that web server to use index.sh as the default document and runs on port 443 with self signed certificates.