search

theonesp / p_zero-code

MIT License
2 stars 1 forks source link

new column in chartevents for units #19

Closed theonesp closed 2 years ago

theonesp commented 2 years ago

Could we get a list of the unit of each vital so it is stored in the table in the proper column? https://github.com/theonesp/p_zero-code/blob/9ade69852b61dd9f8bec1b7b41a0e429588652c2/build_p_zero/etl/postgres/chartevents/chartevents.sql#L21

xborrat commented 2 years ago

I'd rather insert the unit in the dict table. Once we have the d_items table I'll do it.

theonesp commented 2 years ago

MIMIC includes them in both d_items and chartevents, though. let's Weigh up pros and cons

theonesp commented 2 years ago

we decided to exclude units from chartevents, it will be more efficient and OMOP does not use units either.