Closed mparent61 closed 8 years ago
LGTM
On Tue, Jan 19, 2016 at 4:55 PM, Mike Parent notifications@github.com wrote:
TODO
- add filters
You can view, comment on, or merge this pull request online at:
https://github.com/theonion/django-bulbs/pull/103 Commit Summary
- Initial special coverage resolve.
- Add tunic_campaign_id fields
- Fix test to work in Python 2.7
- Use same URL name structure as content-resolve
File Changes
- M bulbs/api/views.py https://github.com/theonion/django-bulbs/pull/103/files#diff-0 (41)
- A bulbs/content/migrations/0006_content_tunic_campaign_id.py https://github.com/theonion/django-bulbs/pull/103/files#diff-1 (19)
- M bulbs/content/models.py https://github.com/theonion/django-bulbs/pull/103/files#diff-2 (4)
- A bulbs/special_coverage/migrations/0008_auto_20160118_1337.py https://github.com/theonion/django-bulbs/pull/103/files#diff-3 (20)
- M bulbs/special_coverage/models.py https://github.com/theonion/django-bulbs/pull/103/files#diff-4 (4)
- M setup.py https://github.com/theonion/django-bulbs/pull/103/files#diff-5 (2)
- A tests/api/test_resolve_api.py https://github.com/theonion/django-bulbs/pull/103/files#diff-6 (106)
Patch Links:
- https://github.com/theonion/django-bulbs/pull/103.patch
- https://github.com/theonion/django-bulbs/pull/103.diff
— Reply to this email directly or view it on GitHub https://github.com/theonion/django-bulbs/pull/103.
OK @benghaziboy @MichaelButkovic ready for review
LGTM
Adds new centralized "tunic_campaign_id", will eventually rename to campaign_id once migrated.
TODO