search

theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)
MIT License
26 stars 7 forks source link

initial implementation #111

Closed camsom closed 8 years ago

camsom commented 8 years ago

@mparent61

This will be imported into the respective reading_lists to add the appropriate query.

mparent61 commented 8 years ago

Otherwise LGTM I think this is the most flexible approach. Only immediate downside is the extra code to check for IndexErrors and such -- maybe that could be streamlined by some wrapper if we continue this approach?

camsom commented 8 years ago

@mparent61 updated this to include the next calls from the most recent djes updates

mparent61 commented 8 years ago

Much cleaner with next(). As I think you mentioned in the djes update, will the next() call make repeated ES backend queries on subsequent calls against the same query? Or will caching ensure ES is only hit once?

camsom commented 8 years ago

@mparent is this good to go?

MichaelButkovic commented 8 years ago

:+1:

camsom commented 8 years ago

blessings