Initial videohub_client integration

theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)

MIT License

26 stars 7 forks source link

Initial videohub_client integration #211

Closed mparent61 closed 8 years ago

mparent61 commented 8 years ago

Merging videohub_client.VideohubVideo support into Bulbs for standard Video interface

Each property's Video content models will inherit from new VideoMixin

Does not contain any breaking changes, as the updated Video filters aren't yet used by any properties.

mparent61 commented 8 years ago

Add recent videos method with optional number in content model

coveralls commented 8 years ago

Coverage increased (+0.009%) to 86.164% when pulling ad3b245c2c385d2c290a442cec49bd96cedc7769 on videohub-video into 8028d23f01e522b1803d8813f61ba470d87a3dd8 on master.

coveralls commented 8 years ago

Coverage increased (+0.009%) to 86.164% when pulling a32af2ee89bbb61e19e45acee8f4765c7d3905e1 on videohub-video into 8028d23f01e522b1803d8813f61ba470d87a3dd8 on master.

MichaelButkovic commented 8 years ago

I think I would be in favor of just moving the client in now. Looks good thus far, otherwise.

coveralls commented 8 years ago

Coverage decreased (-0.09%) to 86.069% when pulling cd4e08956af9062102ecb44db94dad4386ebc0b9 on videohub-video into 8028d23f01e522b1803d8813f61ba470d87a3dd8 on master.

mparent61 commented 8 years ago

Now folds entire videohub-client library into videos app.

This can be deployed in parallel to videohub_client, but will eventually require client migrations.

coveralls commented 8 years ago

Coverage increased (+0.009%) to 86.069% when pulling 8b126cfed222a438ef3a75a863993349eb3dda44 on videohub-video into 4e2b196565a0697c5c3b2a45bb9c4ab7b00c8c40 on master.

coveralls commented 8 years ago

Coverage increased (+0.009%) to 86.069% when pulling 7a8bbc6686762f419e09036963a77da05704ba3a on videohub-video into 181f58be90e2990bc3f8e1b22832f9bb20340bad on master.

mparent61 commented 8 years ago

@benghaziboy @MichaelButkovic @collin

I went ahead and merged videohub-client into django-bulbs. These changes won't break existing properties (but properties will require their own migration dance). When we're done we'll have a more-consistent Video model.

coveralls commented 8 years ago

Coverage increased (+0.009%) to 86.178% when pulling 683558aa4427ac9c92bc883e7e2e047846075bfa on videohub-video into 8399a47fedf2ad691d9b4254a9c297a5dc13a4de on master.

coveralls commented 8 years ago

Coverage increased (+0.009%) to 86.178% when pulling 683558aa4427ac9c92bc883e7e2e047846075bfa on videohub-video into 8399a47fedf2ad691d9b4254a9c297a5dc13a4de on master.

coveralls commented 8 years ago

Coverage increased (+0.009%) to 86.178% when pulling 683558aa4427ac9c92bc883e7e2e047846075bfa on videohub-video into 8399a47fedf2ad691d9b4254a9c297a5dc13a4de on master.

camsom commented 8 years ago

pending tests 👍 ayyyy

MichaelButkovic commented 8 years ago

LGTM👍

coveralls commented 8 years ago

Coverage increased (+0.009%) to 86.178% when pulling 5cef77bdf49b2372981cd518c4f3dc168ddd3275 on videohub-video into 8399a47fedf2ad691d9b4254a9c297a5dc13a4de on master.