search

theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)
MIT License
26 stars 7 forks source link

Add optional AppConfigs as workaround for duplicate app names #227

Closed mparent61 closed 8 years ago

mparent61 commented 8 years ago

Workaround for Django errors attempting to install 2 apps with same name (ex: bulbs.videos and starwipe.apps.videos). Projects can choose to explicitly include these AppConfigs with namespaced labels.

INSTALLED_APPS = [
   ...
   "bulbs.videos.apps.AppConfig",
   ...
]

And then refer to the app as bulbs_videos.

Note: I did not make these defaults (default_app_config = 'bulbs.videos.apps.AppConfig') to avoid breaking existing integrations). Integrations must explicitly use .app.AppConfig as needed.

mparent61 commented 8 years ago

@benghaziboy @MichaelButkovic

Also @MelizzaP can you test this with bulbs.ads?

camsom commented 8 years ago

lgtm. We'll want to decide if this is our long term solution however

MichaelButkovic commented 8 years ago

LGTM

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.1%) to 84.739% when pulling e50adb378b90f824561347f6dd288772c2a680b4 on app-configs into b8680d52d6cf8722e6a52fca46acd9c2baf869df on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.1%) to 84.739% when pulling e16fd3a264091b901aa2213ec3f414ed4937ae71 on app-configs into b8680d52d6cf8722e6a52fca46acd9c2baf869df on master.