update styles for mobile ads

theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)

MIT License

26 stars 7 forks source link

update styles for mobile ads #236

Closed MelizzaP closed 8 years ago

MelizzaP commented 8 years ago

added some styling for mobile inread ads

MelizzaP commented 8 years ago

More Mobile Ad Inventory on longer articles

MelizzaP commented 8 years ago

@spra85 @jmelvnsn

spra85 commented 8 years ago

Have a test link @MelizzaP ?

MelizzaP commented 8 years ago

Can I deploy bulbs to test? I tested this locally on avclub

coveralls commented 8 years ago

Coverage remained the same at 86.232% when pulling 10a2e5c320325dac5f6f03972dee44453a6c4625 on mobile-ad-styles into 78b9ae0aee68db5105d7aa6e56991c8214669559 on master.

coveralls commented 8 years ago

Coverage remained the same at 86.232% when pulling 74465968de2f4246d0efbce1901d8777fe1cd84a on mobile-ad-styles into 78b9ae0aee68db5105d7aa6e56991c8214669559 on master.

coveralls commented 8 years ago

Coverage remained the same at 86.232% when pulling 74465968de2f4246d0efbce1901d8777fe1cd84a on mobile-ad-styles into 78b9ae0aee68db5105d7aa6e56991c8214669559 on master.

coveralls commented 8 years ago

Coverage remained the same at 86.232% when pulling 715b3a44d3da8d5bc6ebcaf07b05bef8b724e48b on mobile-ad-styles into 78b9ae0aee68db5105d7aa6e56991c8214669559 on master.

MelizzaP commented 8 years ago

nevermind, here's a test link! http://adsconfig.test.avclub.com/review/swiss-army-man-somehow-even-crazier-it-looks-238602

check this out on mobile

spra85 commented 8 years ago

👍

coveralls commented 8 years ago

Coverage remained the same at 86.232% when pulling 5b3fdd51ffe7d7ff8700c11d63c8f6f175bb8c83 on mobile-ad-styles into 78b9ae0aee68db5105d7aa6e56991c8214669559 on master.

coveralls commented 8 years ago

Coverage remained the same at 86.233% when pulling b7a9479d5370e9a5354057164aba11859092b82a on mobile-ad-styles into 14db3cf5534360ee96aa5f0e673d23e1a26ebc49 on master.

MelizzaP commented 8 years ago

@jmelvnsn @shawncook can you take a look at this?

shawncook commented 8 years ago

👍 👍 👍 👍 👍 👍 👍 👍 👍

daytonn commented 8 years ago

👍

jmelvnsn commented 8 years ago

Other than my comment 👍

kand commented 8 years ago

👍

MelizzaP commented 8 years ago

👍 rain!!!

coveralls commented 8 years ago

Coverage remained the same at 86.233% when pulling d7ad78bcaf76ba1c59709e4ade05984261393e8d on mobile-ad-styles into 14db3cf5534360ee96aa5f0e673d23e1a26ebc49 on master.