Contribution report streaming

theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)

MIT License

26 stars 7 forks source link

Contribution report streaming #275

Closed mparent61 closed 8 years ago

mparent61 commented 8 years ago

CSV downloads now streamed, preventing timeouts. Previously 1-month queries would hit 60-second server (and possibly browser) timeouts.
Added CSV filenames, and headers are now in fixed ordering (specified by custom Renderers)
Also did some view cleanup.
Test Links (via AVC)

http://fix-payroll-downloads.test.avclub.com/cms/app/reporting/

mparent61 commented 8 years ago

WEBTECH - payroll won't download

mparent61 commented 8 years ago

@benghaziboy ready for review

coveralls commented 8 years ago

Coverage increased (+0.06%) to 86.33% when pulling a457cea12559214deac465c801f5295c4eded7eb on contribution-report-streaming into 2f12e6d92e4c27ec0c919f4df6deda16aab35e85 on master.

camsom commented 8 years ago

outside of potentially duplicating the iterator logic, that I'm not sure of...so we shouldn't get hung up about. 👍

coveralls commented 8 years ago

Coverage increased (+0.06%) to 86.178% when pulling d8c9f8e14db3039c8c5501dd00cb56cd4d209752 on contribution-report-streaming into 469c596f3d3b42d9de6a83ff4a8a6e33a701a70c on master.

mparent61 commented 8 years ago

Maybe, but I don't know about it, and I can't find it in DJES. Eventually this should just be moved into DJES, but I'll pile that on as Tech Debt.

theonion / django-bulbs

Contribution report streaming #275

Test Links (via AVC)