Special Coverage optional end date

theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)

MIT License

26 stars 7 forks source link

Special Coverage optional end date #281

Closed MichaelButkovic closed 8 years ago

MichaelButkovic commented 8 years ago

@mparent61 @benghaziboy

MichaelButkovic commented 8 years ago

Make special coverage end date optional

coveralls commented 8 years ago

Coverage remained the same at 86.194% when pulling d637c2206fd7623b21670ef2ace0c67e4ac30430 on sc-optional-end into 0532a3b617512020751d7e63fa8257a943e10888 on master.

mparent61 commented 8 years ago

There are potentially many filters that will require refactoring to support NULL end dates. Here's just a few from a quick search:

API Filtering: https://github.com/theonion/django-bulbs/blob/501c6a7486f1d0f92e3d8991a05ea574026c6f17/bulbs/api/views.py#L512

Percolator Filtering: https://github.com/theonion/django-bulbs/blob/master/bulbs/content/models.py#L508

coveralls commented 8 years ago

Coverage remained the same at 86.194% when pulling 8bdc7de7a799b9a11ec3b936584f4d3581fd03a7 on sc-optional-end into 0532a3b617512020751d7e63fa8257a943e10888 on master.

coveralls commented 8 years ago

Coverage increased (+0.003%) to 86.197% when pulling acdd05e9f056175a01e548c7fdfecc91669fc2d3 on sc-optional-end into 0532a3b617512020751d7e63fa8257a943e10888 on master.

coveralls commented 8 years ago

Coverage increased (+0.008%) to 86.202% when pulling 1f6fe965651f1b2337ba67636788f20e08543dad on sc-optional-end into 0532a3b617512020751d7e63fa8257a943e10888 on master.

coveralls commented 8 years ago

Coverage decreased (-0.05%) to 86.417% when pulling c06e5998fc305a03ac6e2ea2faa55143933a196e on sc-optional-end into c43f761cb3093741a996bd7bc914f84f8c2e75ae on master.

MichaelButkovic commented 8 years ago

@mparent61 @benghaziboy

coveralls commented 8 years ago

Coverage decreased (-0.05%) to 86.417% when pulling b528bf728525737587e5684f730ea6270a26248f on sc-optional-end into c43f761cb3093741a996bd7bc914f84f8c2e75ae on master.

camsom commented 8 years ago

I give it 💋

mparent61 commented 8 years ago

LGTM

coveralls commented 8 years ago

Coverage increased (+0.007%) to 86.417% when pulling 0806c6f161c294cac1d4d993fd7a939afdf5decf on sc-optional-end into 3f6592866a6c74f296207e86a97853316f7035de on master.

coveralls commented 8 years ago

Coverage increased (+0.007%) to 86.417% when pulling 0806c6f161c294cac1d4d993fd7a939afdf5decf on sc-optional-end into 3f6592866a6c74f296207e86a97853316f7035de on master.

coveralls commented 8 years ago

Coverage increased (+0.007%) to 86.417% when pulling 0806c6f161c294cac1d4d993fd7a939afdf5decf on sc-optional-end into 3f6592866a6c74f296207e86a97853316f7035de on master.

coveralls commented 8 years ago

Coverage increased (+0.03%) to 86.493% when pulling 2ebb0b8a5bb9e8076df279ed1d864dc685ec7a0f on sc-optional-end into 304bcd1e78b00a99ba6dbd36ef902e2755295b2d on master.