search

theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)
MIT License
26 stars 7 forks source link

needed to add data-videohub-base #282

Closed shawncook closed 8 years ago

shawncook commented 8 years ago

hey @spra85 @collin @MelizzaP does this look correct to you? Still trying to figure out how to test it, but I'm pretty sure this'll fix this bug.

  if (typeof this.$videohubBaseUrl === 'undefined') {
    throw Error('CurrentEpisode requires bulbs-video to have a videohub base url.');
  }

☝️ i think this is what is causing the problem

collin commented 8 years ago

I think the the script causing this bug shouldn't even be running on the home page.

And if it is going to run on the homepage, it shouldn't be selecting $('bulbs-video') so generally.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 86.194% when pulling 480c822684bc88f1566bc9e9de42c91677425bf8 on urlfix into 0532a3b617512020751d7e63fa8257a943e10888 on master.

shawncook commented 8 years ago

You're right. I made a new PR on onion here: https://github.com/theonion/onion/pull/535