theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)
MIT License
26 stars 7 forks source link

Add LiveBlog support #284

Closed mparent61 closed 8 years ago

mparent61 commented 8 years ago

Provides models and API endpoints for LiveBlog implementations.

AVC Reference Implementation: https://github.com/theonion/avclub/pull/547

mparent61 commented 8 years ago

Build endpoints

mparent61 commented 8 years ago

@benghaziboy @MichaelButkovic Putting this out for early review

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 86.194% when pulling a750ca9956fdcb8f66632f085fcc5e6d65c3de91 on liveblog into 0532a3b617512020751d7e63fa8257a943e10888 on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 86.194% when pulling a750ca9956fdcb8f66632f085fcc5e6d65c3de91 on liveblog into 0532a3b617512020751d7e63fa8257a943e10888 on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 86.194% when pulling a750ca9956fdcb8f66632f085fcc5e6d65c3de91 on liveblog into 0532a3b617512020751d7e63fa8257a943e10888 on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 86.194% when pulling e3c151ae9d0b53e9351265535c62ca482bb8d7a1 on liveblog into 0a2ac72d9c8d8bb4660f535e1e749d22a052fc82 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 86.41% when pulling a3e1e6c1facec5c770968c1b942f562d7011e1ce on liveblog into 0a2ac72d9c8d8bb4660f535e1e749d22a052fc82 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 86.41% when pulling 5ef90ec919411427dd5ef09a521929e7202cf41d on liveblog into 0a2ac72d9c8d8bb4660f535e1e749d22a052fc82 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 86.412% when pulling efc744d18731d3cbfac3f4dcacc376e571136b64 on liveblog into 0a2ac72d9c8d8bb4660f535e1e749d22a052fc82 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 86.412% when pulling 7a2bbb59f4fc6071b58b9f8449d57cbfe47a2aa4 on liveblog into 72fe56f07f5fa46b2712b8b71aec5c82f7efb011 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 86.375% when pulling 7a2bbb59f4fc6071b58b9f8449d57cbfe47a2aa4 on liveblog into 72fe56f07f5fa46b2712b8b71aec5c82f7efb011 on master.

mparent61 commented 8 years ago

@MichaelButkovic @kand @benghaziboy Ready for Review

Please critique my RESTful-ness. I added a "liveblog_id" filter to the LiveBlogEntryViewSet to avoid creating a separate viewset keyed by Live Blog ID, let me know if there is a more preferred way to do this.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 86.421% when pulling cc3e3fea39689e6ff40474618c3fc0f1cc277dd2 on liveblog into 72fe56f07f5fa46b2712b8b71aec5c82f7efb011 on master.

mparent61 commented 8 years ago

@benghaziboy Cleaned up migrations using swappable_dependency, worked very smoothly with AVC integration.

Had to squash the example.testcontent migrations, as swappable_dependency requires the first migration to contain the necessary dependencies (i.e. TestLiveBlog).

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 86.372% when pulling 20ffbe9845ac76cb0684869aed481fa630bbefdb on liveblog into 72fe56f07f5fa46b2712b8b71aec5c82f7efb011 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 86.41% when pulling 6a0b0b90b7bee5f396dcb8e4141512684a6342ef on liveblog into de179606e7abd3721dd58d577bb892cbe0b0c904 on master.

mparent61 commented 8 years ago

Will merge this unless any comments on API / etc.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 86.46% when pulling d149adc6ba06b0650a60b3d24705dcf47307a226 on liveblog into 1793b94690dd84d30951de4ceb2d8d07fd067543 on master.