LiveBlog: Various updates

theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)

MIT License

26 stars 7 forks source link

LiveBlog: Various updates #301

Closed mparent61 closed 8 years ago

mparent61 commented 8 years ago

Building up list of minor LiveBlog improvements

DELETE endpoint doc + tests
LiveBlogResponse default ordering
FIrebase entry update integration

coveralls commented 8 years ago

Coverage remained the same at 86.481% when pulling bcdaf6c61db3c386e1a1ca2747d90e0318d8433b on liveblog-updates into f313fee27aedb089dd371b6f255f0fd40886959b on master.

coveralls commented 8 years ago

Coverage decreased (-0.07%) to 86.41% when pulling c46bf11a1ae0cdf1059ed7218d7bcaeb8a823661 on liveblog-updates into f313fee27aedb089dd371b6f255f0fd40886959b on master.

mparent61 commented 8 years ago

@collin Updated Firebase updatedAt to use ISO date string (same as the "if_modified_since" param)

coveralls commented 8 years ago

Coverage increased (+0.02%) to 86.428% when pulling f334c1ea545f3f0deed5b7d5b00b862c80a1342c on liveblog-updates into 965c61d40156c96579e9fc882c3af346dd75ad6f on master.

coveralls commented 8 years ago

Coverage increased (+0.02%) to 86.428% when pulling f334c1ea545f3f0deed5b7d5b00b862c80a1342c on liveblog-updates into 965c61d40156c96579e9fc882c3af346dd75ad6f on master.

coveralls commented 8 years ago

Coverage increased (+0.05%) to 86.464% when pulling f334c1ea545f3f0deed5b7d5b00b862c80a1342c on liveblog-updates into 965c61d40156c96579e9fc882c3af346dd75ad6f on master.

coveralls commented 8 years ago

Coverage increased (+0.05%) to 86.464% when pulling f334c1ea545f3f0deed5b7d5b00b862c80a1342c on liveblog-updates into 965c61d40156c96579e9fc882c3af346dd75ad6f on master.

coveralls commented 8 years ago

Coverage increased (+0.05%) to 86.464% when pulling ee3ad302334710c2fa11824c08278e79a9c5369a on liveblog-updates into 3f6592866a6c74f296207e86a97853316f7035de on master.

coveralls commented 8 years ago

Coverage increased (+0.05%) to 86.464% when pulling ee3ad302334710c2fa11824c08278e79a9c5369a on liveblog-updates into 3f6592866a6c74f296207e86a97853316f7035de on master.

mparent61 commented 8 years ago

@benghaziboy @MichaelButkovic @collin

Ready for review

MichaelButkovic commented 8 years ago

LGTM

mparent61 commented 8 years ago

Add a hook for firebase in the backend

coveralls commented 8 years ago

Coverage decreased (-0.08%) to 86.335% when pulling 043b2db68bf3da19acaa952ac2fe66b0b9bac424 on liveblog-updates into 3f6592866a6c74f296207e86a97853316f7035de on master.

coveralls commented 8 years ago

Coverage increased (+0.05%) to 86.464% when pulling 043b2db68bf3da19acaa952ac2fe66b0b9bac424 on liveblog-updates into 3f6592866a6c74f296207e86a97853316f7035de on master.

collin commented 8 years ago

https://github.com/theonion/django-bulbs/blob/master/bulbs/liveblog/filters.py#L21

If we're going to be passing this value straight through, should that be gte? so we'll match the most recent update.

return queryset.filter(published__gt=when)

mparent61 commented 8 years ago

@collin and I discussed a new solution (going to remove this JSON endpoint and add an HTML partial endpoint instead). I'll make a new PR