theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)
MIT License
26 stars 7 forks source link

remove lodash dependency inside of mobile ad placer #329

Closed MelizzaP closed 8 years ago

MelizzaP commented 8 years ago

Removed lodash dependency b/c it was giving me grief with test and require.js, I was only using lodash's _.words function which breaks up a string into individual words

test-link: http://bulbs-bump.test.avclub.com/article/chocolate-croissants-montreal-layers-pastry-and-pr-240938

ch test link: http://clickhole-mobile-ad-placer.test.clickhole.com/article/silencing-dissent-donald-trump-just-threw-elderly--4815

check it out on mobile, it should place ads after every 350 words only in between paragraphs

MelizzaP commented 8 years ago

Mobile Ad Inventory

MelizzaP commented 8 years ago

@daytonn @kand @collin ready for reviewwwwww

kand commented 8 years ago

👍