search

theonion / django-bulbs

DEPRECATED: This project is now part of the Mono Repo (https://github.com/theonion/omni)
MIT License
26 stars 7 forks source link

exclude super features from content list #331

Closed MichaelButkovic closed 8 years ago

MichaelButkovic commented 8 years ago

@mparent61 @benghaziboy @kand we had talked about doing this instead of using the exclude query param, so i did it

camsom commented 8 years ago

👍

kand commented 8 years ago

So the exclude query param is now unused?

MichaelButkovic commented 8 years ago

once this is merged, yeah. we can still include it if we want, but since it's only being used for super features, i think it's fine to remove

mparent61 commented 8 years ago

Since we already have the "exclude" query param logic, why not keep it, but have the view always append SF doc type to the exclude list? Seems like exclude would be handy in the future.

MichaelButkovic commented 8 years ago

sure, that's fair

kand commented 8 years ago

👍

mparent61 commented 8 years ago

👍