search

theonion / videojs-vast-plugin

A VideoJS plugin for VAST
theonion.github.io/videojs-vast-plugin/
MIT License
264 stars 173 forks source link

Problem when using Wrapper, VASTAdTagURI and TrackingEvents #51

Open ghost opened 10 years ago

ghost commented 10 years ago

I don’t know much about VAST but I’ve been trying to setup this plugin. It worked nicely on some simple examples but as soon as I was using the actual XML VAST definition that I need to use, it wouldn’t work and I would get javascript errors about my tracking events. Removing the tracking events would fix the issue.

The errors were from vast-client.js. You can see the issue I opened here https://github.com/dailymotion/vast-client-js/issues/53. But then, I tried updating the the latest vast-client and that seems to fix the issue!

It would probably be a good thing to update to the latest vast-client.js in this repo. I just have no idea if this breaks some things or not.

csinchok commented 10 years ago

Thanks for the tip, we're doing some work on this repo right now, so I'll make sure that gets updated!