search

theonlydude / varia_custom_sprites

GNU General Public License v3.0
2 stars 2 forks source link

Fixed it, but is sounds a bit different #4

Closed H-A-M-G-E-R closed 9 months ago

H-A-M-G-E-R commented 9 months ago

fixes issue #3

theonlydude commented 9 months ago

Hello, thanks for the PR, there's indeed no more memory violation:

dude@computer:~/RandomMetroidSolver/tools (solver_objectives)$ ./check_nspc.py ../varia_custom_sprites/music/MMC_Server/Custom_Parasite_Queen_v1.0_Fixed_By_HAM.nspc 
../varia_custom_sprites/music/MMC_Server/Custom_Parasite_Queen_v1.0_Fixed_By_HAM.nspc
datablock addr: 0 size: 13140 dest: 0xb210
datablock addr: 13144 size: 28 dest: 0x6d60
datablock addr: 13176 size: 42 dest: 0x6c90
datablock addr: 13222 size: 3538 dest: 0x5828
datablock addr: 16764 size: 2 dest: 0x1cc5
datablock addr: 16770 size: 5 dest: 0x1e8b
datablock addr: 16779 size: 18 dest: 0x56f0
found 7 data blocks
last addr: 16801 last bytes: b'\x00\x00\x00\x15'
  OK size is a match: 16805
data block 0 is inside Sample data
data block 0 is inside   Song-specific sample data
data block 1 is inside Sample table
data block 1 is inside   Song-specific sample table
data block 2 is inside Instrument table
data block 2 is inside   Song-specific instruments (18h..26h)
data block 3 is inside Tracker data
data block 3 is inside   Song-specific tracker data
data block 4 is inside SPC Engine Code
data block 4 is inside SPC Engine Code Total patch 1
data block 5 is inside SPC Engine Code
data block 5 is inside SPC Engine Code Total patch 2
data block 6 is inside Total Patch Extra RAM
data block 6 is inside Unused
  OK no memory violation
H-A-M-G-E-R commented 9 months ago

and i just had to change 1 byte of the nspc to fix it

theonlydude commented 9 months ago

I've just check with old version and it also says no violation...: $ ./check_nspc.py ../varia_custom_sprites/music/MMC_Server/Custom_Parasite_Queen_v1.0.nspc OK no memory violation