search

theopenconversationkit / tock

Tock, the open source conversational AI toolkit.
https://doc.tock.ai
Apache License 2.0
504 stars 132 forks source link

[Tock Studio] Fix templates typing. #1661

Closed rkuffer closed 4 months ago

rkuffer commented 4 months ago

Fix typing errors in templates Activate angularCompilerOptions.strictTemplates Indicate methods overriding in classes Activate compilerOptions.noImplicitOverride

vsct-jburet commented 4 months ago

@rkuffer would be great to squash & to have an other approve from Arkea team - LGTM :)

rkuffer commented 4 months ago

@rkuffer would be great to squash & to have an other approve from Arkea team - LGTM :)

Hi Julien, the PR was approved. About squash, GuitHub offers the Squash & Merge function, which dispenses with local squashing when you've been forced to make a fix after the PR has been published. Doesn't this function suit you?

vsct-jburet commented 4 months ago

@rkuffer would be great to squash & to have an other approve from Arkea team - LGTM :)

Hi Julien, the PR was approved. About squash, GuitHub offers the Squash & Merge function, which dispenses with local squashing when you've been forced to make a fix after the PR has been published. Doesn't this function suit you?

I though that this option would create a merge commit but it seems to do not. So I merge the MR :)