theopenlab / openlab

Used for general work tracking, centralized reporting, easier third-party integration for metrics and data, and more.
Apache License 2.0
5 stars 1 forks source link

terraform-provider-openstack lbaas, trove and faas tests are failing #585

Closed ozerovandrei closed 4 years ago

ozerovandrei commented 4 years ago

We have some issues with lbaas, trove, fwaas tests for terraform-provider-openstack.

Could you please help?

LBaaS

Error from logs devstacklog.txt:

2020-09-19 13:35:47.936 | ++ /opt/stack/new/octavia/devstack/plugin.sh:build_octavia_worker_image:126 :   /opt/stack/new/octavia/diskimage-create/diskimage-create.sh -l /var/log/dib-build/amphora-x64-haproxy.qcow2.log -x -o /opt/stack/new/octavia/diskimage-create/amphora-x64-haproxy.qcow2
2020-09-19 13:35:48.150 | /opt/stack/new/octavia/diskimage-create/diskimage-create.sh: line 500: disk-image-create: command not found

How to reproduce:

Type recheck lbaas in test pr: https://github.com/terraform-provider-openstack/terraform-provider-openstack/pull/1067

Trove

Trove tests are failing with the following error job-output.txt.gz:

020-09-19 14:29:16.557514 | ubuntu-bionic | [3309] /opt/stack/new/trove/integration/scripts$ /opt/stack/new/trove/integration/scripts/trovestack kick-start mysql
2020-09-19 14:29:17.436285 | ubuntu-bionic | 'kick-start' not a valid command
2020-09-19 14:29:17.437944 | ubuntu-bionic | ERROR: InvocationError for command /opt/stack/new/trove/integration/scripts/trovestack kick-start mysql (exited with code 1)
2020-09-19 14:29:17.438146 | ubuntu-bionic | trovestack finish: run-test  after 0.91 seconds
2020-09-19 14:29:17.439074 | ubuntu-bionic | trovestack start: run-test-post
2020-09-19 14:29:17.439249 | ubuntu-bionic | trovestack finish: run-test-post  after 0.00 seconds
2020-09-19 14:29:17.440049 | ubuntu-bionic | ___________________________________ summary ____________________________________
2020-09-19 14:29:17.440193 | ubuntu-bionic | ERROR:   trovestack: commands failed
2020-09-19 14:29:17.698792 | ubuntu-bionic | ERROR

How to reproduce:

Type recheck trove in test pr: https://github.com/terraform-provider-openstack/terraform-provider-openstack/pull/1067

FWaaS

Devstack successfully installs but all Terraform HTTP requests are failing with the Resource not found error. Maybe fwaas plugins are not enabled in the Networking service.

How to reproduce:

Type recheck fwaas in test pr: https://github.com/terraform-provider-openstack/terraform-provider-openstack/pull/1067

wangxiyuan commented 4 years ago

For LBaaS:

https://github.com/openstack/octavia/commit/59c4ad48323dac163148a94e7b37df1af9254ce2

diskimage-builder is removed from octavia requirements.txt, And a new one is added in diskimage-create/requirements.txt. But the new file is not called by devstack so that the error raised here.

I think updating devstack/plugin.sh in Octavia should be the best fix way.

Of cause, adding LIBS_FROM_GIT=diskimage-builder into devstack local.conf file should be a quick fix way in openlab zuul job.

wangxiyuan commented 4 years ago

For fwaas:

see: https://github.com/theopenlab/openlab-zuul-jobs/blob/master/roles/create-devstack-local-conf/tasks/main.yml#L205-L206

you can see that the openlab job defination uses https://opendev.org/openstack/neutron-fwaas which is deprecated already. It should use the new one instead. But I don't know how fwaas works in OpenStack Upstream now.

Feel free to update it.

wangxiyuan commented 4 years ago

Need more time to look the problem in Trove.

jtopjian commented 4 years ago

The diskimage-builder error is also affecting Gophercloud.

ozerovandrei commented 4 years ago

LBaaS tests are working now since there was a fix in the upstream: https://github.com/openstack/octavia/commit/cb7d5133e7d3082c32a505cebf3ee6167fec4812

I haven't known about FWaaS V1 deprecation, thank you for the explanation!

wangxiyuan commented 4 years ago

Not only FWaaS V1 API, It looks that neutron-fwaas has been deprecated totally. I guess this project shoulde be removed from CI now.

wangxiyuan commented 4 years ago

@ozerovandrei For Trove, the command kick-start which the job uses is remove from the commit https://github.com/openstack/trove/commit/602c4d42de77d1be0397185b04f2790f4bae87b7

So there must be a new way to setup the test env. I'm not familar with trove, you can take a look at Trove , ask Trove commuinty and update the openlab job then. https://github.com/theopenlab/openlab-zuul-jobs/blob/master/playbooks/terraform-provider-openstack-acceptance-test-trove/run.yaml#L25

ozerovandrei commented 4 years ago

@wangxiyuan thank you for the help!