Closed gabrielegranello closed 2 months ago
vercel[bot]
commented
2 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| fairhold-dashboard | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 26, 2024 7:01am |
gabrielegranello
commented
2 months ago Looks good to me, nice work on the cherry pick!
Small thing for future: maybe it would have been better separation of concerns to leave the loading spinner in a separate branch / PR?
Yes you are 100% sorry about that. Actually the spinner was an independent PR originally, but then it was caught in all the rebasing mess. Lesson learnt for the future
What does this PR do?
After making a mess with all the commits which made the review impossible, I used the cherry pick command to actually select the meaningful ones. Essentially: 1) It creates a new schema for passing the data to the API. 2) It adds a spinning wheel while loading the data 3) It adds the useForm react command instead of useState. This allows also to validate the form data.