[x] Shift labels on "remove" so they stay incremental
[x] Ensure previously working handleSubmit & "back"/"change" navigation still works
This is honestly still a bit wonky but I think less vital for UR than that actual "remove" functionality !!
See #3612 for original implementation, which isn't ideal in combo with new GeoJSONChange hook here
Open questions:
When removing a feature, I'm forcing a re-render of the web component by changing a key prop on its' parent container which does cause a visible flash - is this acceptable? Other less hacky feeling ideas?
Tried many other variations but was having a hard time getting the web component to re-render based on changing features alone - I think this is most likely due to Lit's "shallow change detection"
Spent some time reading up on Lit Events, but not totally clear to me if an event listener would be another way to solve this?
Thanks @DafyddLlyr for thorough review here - merging to staging for UR deadline, but will open follow PRs today to address these comments / fix-forward !
Rebased version of #3595
My changes (builds on 3595 description):
handleSubmit
& "back"/"change" navigation still worksGeoJSONChange
hook hereOpen questions:
key
prop on its' parent container which does cause a visible flash - is this acceptable? Other less hacky feeling ideas?features
alone - I think this is most likely due to Lit's "shallow change detection"