theopensystemslab / planx-new

Planβœ• is a platform for creating and publishing digital planning services
https://editor.planx.uk
Mozilla Public License 2.0
13 stars 2 forks source link

test[e2e]: add more components to create-flow test #3630

Closed jamdelion closed 2 days ago

jamdelion commented 2 weeks ago

In this PR

βœ… I think this is the end of the 'straightforward' components, at least from the adding to a flow side.

βš”οΈ There are other components still to cover, but are difficult or skipped here because:

Still to do πŸ“

❓ Questions

github-actions[bot] commented 2 weeks ago

Removed vultr server and associated DNS entries

jamdelion commented 3 days ago

This is looking great πŸ™Œ

I'd recommend trying out the Fixture pattern Playwright uses - this would like remove a lot of the boilerplate of passing around page and locationNode and allow us to better model our pages.

Thanks @DafyddLlyr - I'm trying this out in the next PR: https://github.com/theopensystemslab/planx-new/pull/3683/files#diff-1307319267989b018c8a9fe05fcaf699ea2d8459c020391fea5868e32719e8dfR108-R127. So far it only looks like I've moved the complexity around a bit but I'm hoping to find a way to "fixturize" this and make it useful for the other tests in create-flow.spec.ts