Closed jamdelion closed 2 days ago
Removed vultr server and associated DNS entries
This is looking great π
I'd recommend trying out the Fixture pattern Playwright uses - this would like remove a lot of the boilerplate of passing around
page
andlocationNode
and allow us to better model our pages.
Thanks @DafyddLlyr - I'm trying this out in the next PR: https://github.com/theopensystemslab/planx-new/pull/3683/files#diff-1307319267989b018c8a9fe05fcaf699ea2d8459c020391fea5868e32719e8dfR108-R127. So far it only looks like I've moved the complexity around a bit but I'm hoping to find a way to "fixturize" this and make it useful for the other tests in create-flow.spec.ts
In this PR
β I think this is the end of the 'straightforward' components, at least from the adding to a flow side.
βοΈ There are other components still to cover, but are difficult or skipped here because:
Still to do π
β Questions
data-placeholder
rather thanplaceholder
which makes it harder to grab them in tests. Is there a way round this/can they be changed from data-placeholder to a normal placeholder attribute?